[history server] Add initial version of event server for history server.#4253
[history server] Add initial version of event server for history server.#4253chiayi wants to merge 2 commits intoray-project:masterfrom
Conversation
Co-authored-by: chiayi chiayiliang327@gmail.com Co-authored-by: KunWuLuan kunwuluan@gmail.com
|
Manually tested using @KunWuLuan 's historyserver and collector. Assuming that the events are stored in Running the eventserver will read these files and turn them into task objects. I've also temporary replaced the historyserver endpoint and function getTaskDetail() to return the unformatted list of tasks. Running |
| logrus.Infof("Event processor received stop signal, exiting.") | ||
| return | ||
| default: | ||
| // S3, minio, and GCS are flat structures, object names are whole paths |
There was a problem hiding this comment.
is there anything we'd need to do to ensure hygiene for azure blob storage originating data?
There was a problem hiding this comment.
I think no, for more details about object's path, you can refer the design doc here
https://github.com/ray-project/enhancements/blob/main/reps/2025-11-21-ray-history-server/2025-11-21-ray-history-server.md#file-structure-for-persisted-events--logs
|
Thanks for the PR! I think the high level approach looks good! Some a bit detailed comment:
I'll wait for more polished version of the PR to do more detailed review. |
Future-Outlier
left a comment
There was a problem hiding this comment.
If there's some field we can't get from ray event, should we get it from log dir?
for example, get the task field profiling_data from
{session_dir}/logs/export_events/event_EXPORT_TASK.log
Future-Outlier
left a comment
There was a problem hiding this comment.
Hi, can you show me step by step how to test this PR in local env using kind?
It will be very helpful for me if you can show how where the event processor call Run and get data from the object storage.
for example, it would be helpful if there's a guide like this.
|
There was a problem hiding this comment.
Hi, @chiayi Happy New Year!
After the holidays, if you have time, let’s schedule a meeting to implement a version that provides HTTP endpoints.
Your design doc makes sense to both Meng Jing and me. Thanks!
Hi @Future-Outlier , Happy New Year to everyone! |
Hi, @fangyinc |
|
Hi, @chiayi, @Future-Outlier, it looks like this PR currently has conflicts with the master branch. Could someone please resolve them? |
Co-authored-by: @chiayi chiayiliang327@gmail.com
Co-authored-by: @KunWuLuan kunwuluan@gmail.com
Why are these changes needed?
This PR adds the event server part of history server that constructs tasks/actors from ray events.
Related issue number
Related to #3884
Checks